Skip to content

chore: use node 24 #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
feloy merged 1 commit into from
Jan 6, 2026
Merged

chore: use node 24 #350

feloy merged 1 commit into from
Jan 6, 2026
+4 −3

Conversation

@feloy
Copy link
Contributor

@feloy feloy commented Dec 23, 2025

fixes #347

@feloy
chore: use node 24
abf1d9d 
Signed-off-by: Philippe Martin <phmartin@redhat.com>
@feloy feloy requested a review from a team as a code owner December 23, 2025 08:52
@feloy feloy requested review from benoitf, gastoner and simonrey1 and removed request for a team December 23, 2025 08:52
@feloy feloy marked this pull request as draft December 23, 2025 08:52
@coderabbitai
Copy link

coderabbitai bot commented Dec 23, 2025

📝 Walkthrough

Walkthrough

Node.js version requirements are upgraded from 20 to 24 across three CI/CD workflows and project configuration. The changes ensure consistency between development environment, CI/CD pipelines, and declared engine requirements.

Changes

Cohort / File(s) Summary
GitHub Actions Workflows
.github/workflows/build-next.yaml, .github/workflows/pr-check.yaml, .github/workflows/release.yaml		 Updated node-version from 20 to 24 in setup-node action across all three workflows, affecting Node.js environment for downstream build, test, and deployment steps.
Project Configuration
package.json		 Added Node.js engine requirement "node": ">=24.0.0" to engines block to enforce minimum Node.js version.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks

✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: use node 24' clearly and concisely describes the main change: updating Node.js version to 24 across workflows and configuration files.
Description check ✅ Passed The description 'fixes #347' directly references the linked issue that outlines the objective to update Node.js usage to v24, providing the necessary context.
Linked Issues check ✅ Passed The PR successfully addresses issue #347 by updating Node.js version to 24 in workflows and package.json engines, meeting the core requirement to prepare for Node.js v24 compatibility.
Out of Scope Changes check ✅ Passed All changes are directly related to the Node.js v24 update objective; no unrelated modifications to other areas of the codebase were introduced.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eba961d and abf1d9d.

📒 Files selected for processing (4)
  • .github/workflows/build-next.yaml
  • .github/workflows/pr-check.yaml
  • .github/workflows/release.yaml
  • package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build / windows-2022
🔇 Additional comments (4)
.github/workflows/release.yaml (1)

102-102: LGTM!

The Node.js version update is consistent with the other workflows and the package.json engines requirement. This ensures the release workflow uses the same Node.js version as development and CI.

.github/workflows/build-next.yaml (1)

33-33: LGTM!

The Node.js version update is consistent with the other workflows and aligns with the package.json engines requirement. All CI/CD pipelines now use Node.js 24 consistently.

package.json (1)

10-10: Node.js 24 is now in Active LTS and suitable for production.

The engines constraint is appropriate—Node.js 24 entered Long-Term Support (LTS) in October 2025 and will continue receiving maintenance and security updates through April 2028. The >=24.0.0 constraint aligns with the stable LTS release line.

.github/workflows/pr-check.yaml (1)

38-38: actions/setup-node@v6 fully supports Node.js 24.

The actions/setup-node@v6 action has been upgraded to run on Node.js 24 and includes explicit examples with node-version: 24. GitHub runners already support Node.js 24, with the latest runner version 2.328.0 supporting both Node 20 and Node 24. This configuration is fully consistent with the package.json requirement of Node.js >= 24.0.0.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@feloy feloy marked this pull request as ready for review January 5, 2026 08:57
@feloy feloy merged commit 7f3df11 into podman-desktop:main Jan 6, 2026
6 checks passed
@feloy
Copy link
Contributor Author

feloy commented Jan 6, 2026

tested the image built by the CI with node 24, works correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benoitf benoitf benoitf approved these changes

@jeffmaury jeffmaury jeffmaury approved these changes

@axel7083 axel7083 axel7083 approved these changes

@gastoner gastoner gastoner approved these changes

@simonrey1 simonrey1 Awaiting requested review from simonrey1 simonrey1 is a code owner automatically assigned from podman-desktop/reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update usage of Node.js to v24

5 participants

@feloy @benoitf @jeffmaury @axel7083 @gastoner